Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More windows CI debugging #2374

Closed
wants to merge 60 commits into from
Closed

More windows CI debugging #2374

wants to merge 60 commits into from

Conversation

IanButterworth
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member

Use shell: bash

@DilumAluthge
Copy link
Member

Like here: https://github.com/JuliaHealth/FHIRClient.jl/blob/a4eb311777d4619dd960cb0de67e2487d3121072/.github/workflows/ci.yml#L12

Make the default shell bash.

@IanButterworth
Copy link
Member Author

IanButterworth commented Jan 30, 2021 •
edited
Loading

So now it's erroring earlier??

build: Error During Test at D:\a\Pkg.jl\Pkg.jl\test\new.jl:1800
  Test threw exception
  Expression: occursin("oops", read(log_file_add, String))
  SystemError: opening file "C:\\Users\\runneradmin\\AppData\\Local\\Temp\\jl_yqwOcE\\scratchspaces\\44cfe95a-1eb2-52ea-b672-e2afdf69b78f\\f99d57aad0e5eb2434491b47bac92bb88d463001\\build.log": No such file or directory

Pkg.jl/test/new.jl

Lines 1799 to 1800 in f269fd4

@test isfile(log_file_add)
@test occursin("oops", read(log_file_add, String))

Note that this errors on 1800.. after checking the file exists, and this is within a mktempdir block

Edit: the isfile is actually erroring, I just missed it

@DilumAluthge
Copy link
Member

Is there any chance that Julia actually has a tempfile-related bug on Windows, and that's what we're seeing here?

@IanButterworth
Copy link
Member Author

Well, I did file this earlier JuliaLang/julia#39457

@IanButterworth
Copy link
Member Author

@staticfloat could this be a permissions issue pretending to be a file does not exist issue?

@IanButterworth
Copy link
Member Author

IanButterworth commented Jan 30, 2021 •
edited
Loading

Seems like the log file being created has a different directory hash
what build_versions creates:

C:\Users\runneradmin\AppData\Local\Temp\jl_yf3Okr\scratchspaces\44cfe95a-1eb2-52ea-b672-e2afdf69b78f\6d98f21c03273ec8f3a4f547a374fca83dd4b5b6\build.log

what tests expect

"C:\\Users\\runneradmin\\AppData\\Local\\Temp\\jl_yf3Okr\\scratchspaces\\44cfe95a-1eb2-52ea-b672-e2afdf69b78f\\f99d57aad0e5eb2434491b47bac92bb88d463001\\build.log"

@IanButterworth
Copy link
Member Author

IanButterworth commented Jan 30, 2021 •
edited
Loading

I have no idea how isfile passed in #2374 (comment)

Edit: Oh.. it didn't.. I misread the log 🙈

@IanButterworth
Copy link
Member Author

Windows:

stat(joinpath(path, "src", "FailBuild.jl")) = StatStruct(mode=0o100666, size=34)
filemode(joinpath(path, "src", "FailBuild.jl")) = 0x00000000000081b6
stat(joinpath(path, "deps", "build.jl")) = StatStruct(mode=0o100666, size=15)
filemode(joinpath(path, "deps", "build.jl")) = 0x00000000000081b6

Ubuntu

stat(joinpath(path, "src", "FailBuild.jl")) = StatStruct(mode=0o100644, size=31)
filemode(joinpath(path, "src", "FailBuild.jl")) = 0x00000000000081a4
stat(joinpath(path, "deps", "build.jl")) = StatStruct(mode=0o100644, size=14)
filemode(joinpath(path, "deps", "build.jl")) = 0x00000000000081a4

MacOS

stat(joinpath(path, "src", "FailBuild.jl")) = StatStruct(mode=0o100644, size=31)
filemode(joinpath(path, "src", "FailBuild.jl")) = 0x00000000000081a4
stat(joinpath(path, "deps", "build.jl")) = StatStruct(mode=0o100644, size=14)
filemode(joinpath(path, "deps", "build.jl")) = 0x00000000000081a4

@staticfloat staticfloat mentioned this pull request Feb 2, 2021
Merged
@IanButterworth IanButterworth mentioned this pull request Feb 7, 2021
Closed
IanButterworth and others added 16 commits February 7, 2021 15:40
@IanButterworth IanButterworth mentioned this pull request Feb 10, 2021
Merged
@IanButterworth IanButterworth deleted the ib/windows_debug branch February 10, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @DilumAluthge @fredrikekre @staticfloat